> On Oct. 4, 2015, 11:25 a.m., David Faure wrote: > > Albert, in review 122300 (commit b746dcf93239e93eafeedfaeff53e1ac387f5ca1 > > in kcoreaddons), you mentionned that commit was a workaround, I think this > > is the real fix for it?
Actually, it seems so. I can remove the "hack" from that commit and all unittests still pass. Will amend. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125517/#review86325 ----------------------------------------------------------- On Oct. 4, 2015, 11:24 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125517/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2015, 11:24 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kcoreaddons > > > Description > ------- > > BUG: 345140 > > > Diffs > ----- > > autotests/kshelltest.cpp efa6d9b4ff2efb09e017622070ad5174f7c288aa > src/lib/util/kshell_unix.cpp 247d8a2c7b8e10f3dfa108117fb45b1dd4810b07 > > Diff: https://git.reviewboard.kde.org/r/125517/diff/ > > > Testing > ------- > > unittest; clicking on a file with unicode space in dolphin now works. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel