----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125515/#review86340 -----------------------------------------------------------
Looks good! The only thing that I'm not sure about is whether 1000 bytes are guaranteed to be enough. Some quick Googling tells me that path lengths of 4096 are possible. Maybe we could allocate a temporary large array on the heap if the readlink call fails with the 1000 byte buffer on the stack? - Frank Reininghaus On Okt. 4, 2015, 9:24 vorm., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125515/ > ----------------------------------------------------------- > > (Updated Okt. 4, 2015, 9:24 vorm.) > > > Review request for KDE Frameworks. > > > Bugs: 352927 > https://bugs.kde.org/show_bug.cgi?id=352927 > > > Repository: kio > > > Description > ------- > > BUG: 352927 > Change-Id: I7d3c988da32cae9d14750c8adb9ca5af6d140572 > > > Diffs > ----- > > autotests/jobtest.h ef8c3e111ec647cc59c5a9715ab3220ce1651c9e > src/ioslaves/file/file.cpp a0a533c957628b00eff175a949685d4497c5f095 > autotests/jobtest.cpp c24bcead70f78f2bec3b938819fb2fa842e937d5 > > Diff: https://git.reviewboard.kde.org/r/125515/diff/ > > > Testing > ------- > > 2 unit tests added > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
