----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125521/#review86352 -----------------------------------------------------------
src/kdropwidgetdecorator.h (line 37) <https://git.reviewboard.kde.org/r/125521/#comment59482> This isn't really a decorator pattern. It's just a widget. A decorator would probably take a QTabBar as an argument and then create and show this widget as needed depending on how many tabs that tabbar had. src/kdropwidgetdecorator.cpp (line 41) <https://git.reviewboard.kde.org/r/125521/#comment59481> if nothing is connected, or it's a queuedconnection then b is uninitialised. For what this is trying to do, a function pointer might work better. - David Edmundson On Oct. 4, 2015, 7:43 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125521/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2015, 7:43 p.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed > from GPL 2+ to LGPL 2+ with author's permission. > > > Diffs > ----- > > src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 > src/kdropwidgetdecorator.h PRE-CREATION > src/kdropwidgetdecorator.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125521/diff/ > > > Testing > ------- > > It builds, the headers I expect are in the right places, etc. I just noticed > I'm not exporting the class though, will fix that and reupload. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
