> On Oct. 10, 2015, 1:56 p.m., David Faure wrote: > > src/knewpasswordwidget.h, line 65 > > <https://git.reviewboard.kde.org/r/124963/diff/4/?file=399636#file399636line65> > > > > these 9 lines could be done in one or two: > > > > const bool passOk = m_passwordWidget->passwordStatus() == > > WeakPassword || m_passwordWidget->passwordStatus() == StrongPassword; > > m_buttonBox->button(QDialogButtonBox::Ok)->setEnabled(passOk); > > > > But I guess you wanted to show a switch so people could add more code > > in there like showing "your password is too weak"? > > Elvis Angelaccio wrote: > Yeah that was the idea, but indeed is similar to what we already show in > the code snippet right below this one. I'm ok with using your version if you > want.
I'll let you decide, based on what a real application would most probably need. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86631 ----------------------------------------------------------- On Aug. 30, 2015, 8:26 a.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124963/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 8:26 a.m.) > > > Review request for KDE Frameworks and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > This widget is a stripped-down version of KNewPasswordDialog, without any > dialog-specific stuff. > > ### Why a new widget? > > This widget is meant to be easily embedded in any custom password dialog, > including KNewPasswordDialog. It's the least common denominator of features > that any password dialog should offer to the user. > > ### Features > > * Password visibility action (same as RR 124698). The password verification > field is hidden if the user shows the password. > * Background warning colour. The password verification field gets a coloured > background whenever the password and its verification don't match. (feature > borrowed from Keepass) > * Password status signal. This allows the upper level dialogs to update their > stuff (enable/disable OK button, show warnings for low password strength, > etc.) > * Password strength bar can be hidden. > * Unit test. > > ### Use cases > At least the following: > > * Ark (new archive dialog) > * KNewPasswordDialog refactoring (my next RR if this one gets accepted) > > > Diffs > ----- > > autotests/CMakeLists.txt ac708ef33e3be89db85d43911f96e536c52f741d > autotests/knewpasswordwidgettest.h PRE-CREATION > autotests/knewpasswordwidgettest.cpp PRE-CREATION > src/CMakeLists.txt e03e9bbd6d73811873b0a465f86da269f4295138 > src/knewpasswordwidget.h PRE-CREATION > src/knewpasswordwidget.cpp PRE-CREATION > src/knewpasswordwidget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124963/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > knewpasswordwidget1.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/5796469c-28b7-4151-b9cb-6a327631db75__knewpasswordwidget1.png > knewpasswordwidget2.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/b3bfc9ac-ab8e-404c-8091-b5ad9e3e054f__knewpasswordwidget2.png > knewpasswordwidget3.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/28/dfaeea4e-65da-4961-b266-986a21f54ca7__knewpasswordwidget3.png > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
