> On Oct. 9, 2015, 6:42 p.m., David Edmundson wrote: > > src/kaboutapplicationdialog.cpp, line 94 > > <https://git.reviewboard.kde.org/r/125575/diff/1/?file=410377#file410377line94> > > > > This doesn't seem right. Sorry. > > > > setDevicePixelRatio should really only be done when loading/creating a > > pixmap that has actually taken the devicePixelRatio into account. > > > > What your patch is doing is effectively saying; if I have a 32px logo > > draw me at 32 device pixels on the device no matter what the resolution of > > the device is. > > > > So, it won't look pixelated, but it'll also only be quarter of the size > > on the screen than it will be on a "normal" monitor. > > Christoph Cullmann wrote: > ok ;=) Have you some better idea? We could add support for QIcon and then > load the image with different size? Or would that happen, too, if we have > this 2x/4x naming scheme? > > Christoph Cullmann wrote: > In any case, the approach is wrong, you are right, will think more about > it.
I think that's what the @2x stuff is meant for. Saves putting anything in any code. Though I also think it's a bit unusual for KTitleWidget to display pixmaps at the raw native resolution of the supplied pixmap. Means it'll be generally inconsistent in different places. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125575/#review86566 ----------------------------------------------------------- On Oct. 11, 2015, 2:07 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125575/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2015, 2:07 p.m.) > > > Review request for KDE Frameworks and David Edmundson. > > > Repository: kxmlgui > > > Description > ------- > > e.g. the KatePart logo is pixelated (look at help -> about editor component > in kate). > now it looks at least nice. > > An other solution could be to create the pixmap in katepart in the > setProgramLogo call, but that will then need adjustments at all places used > in other applications, too. > > > Diffs > ----- > > src/kaboutapplicationdialog.cpp f8bfe7b > > Diff: https://git.reviewboard.kde.org/r/125575/diff/ > > > Testing > ------- > > Kate without that patch => pixelated logo > Kate with that patch => nice logo ;) > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
