----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/#review86681 -----------------------------------------------------------
src/CMakeLists.txt <https://git.reviewboard.kde.org/r/125595/#comment59665> I think you should still install it. Otherwise code like http://lxr.kde.org/source/frameworks/kparts/src/mainwindow.cpp line 0170 will break (of course that particular one needs fixing, e.g. by using :/kxmlgui5/ui_standards.rc too). Still, I'd preserve compat by installing the file. - David Faure On Oct. 11, 2015, 9:45 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125595/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2015, 9:45 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kxmlgui > > > Description > ------- > > Bundle the one needed .rc file in a resource. > > The patch is now updated to pack all assets of kxmlgui into a resource file, > zero installed files needed. > Btw., for HighDPI screens, we might want later to pack at least some 2x image > in for the about kde stuff. > > > Diffs > ----- > > src/CMakeLists.txt 949da5e > src/kaboutapplicationpersonlistdelegate_p.cpp 5214288 > src/kaboutkdedialog_p.cpp 0261b85 > src/kxmlgui.qrc PRE-CREATION > src/kxmlguiclient.cpp 01103ef > > Diff: https://git.reviewboard.kde.org/r/125595/diff/ > > > Testing > ------- > > Bundle ui_standards.rc in a resource, still allow to overwrite it, like > before. This makes it possible to use this framework on win/mac without any > QStandardPaths patches. This patch is still missing the matching .qrc file, I > wanted first to know if that fallback is OK. The idea would be to add this > and not install the ui_standards.rc by default and only compile it in. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
