----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125640/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kwallet Description ------- As pointed out in https://git.reviewboard.kde.org/r/125483/ the special handling is useless here. If the service is registered, it will call Activate and KDBusService will just exit, even with the NoExitOnFailure flag; it would never reach the "if (!dbusUniqueInstance.isRegistered()) {". Furthermore, without the NoExitOnFailure flag, it would exit right from KDBusService, rendering this whole if-block kinda useless. Diffs ----- src/runtime/kwalletd/main.cpp fbab58d Diff: https://git.reviewboard.kde.org/r/125640/diff/ Testing ------- Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
