> On Oct. 11, 2015, 9:03 p.m., David Faure wrote: > > src/CMakeLists.txt, line 24 > > <https://git.reviewboard.kde.org/r/125556/diff/3/?file=410588#file410588line24> > > > > Well, then the lib itself shouldn't be called KF5MediaWiki? > > > > But of course changing this is only possible if it hasn't been released > > yet. > > Dāvis Mosāns wrote: > idk, ask it whoever is maintaining it :D it doesn't really matter for me > what it's called :P > but if it's changed it will need changes in like kipi-plugins (and maybe > elsewhere) because currently it uses KF5MediaWiki
It looks like it hasn't been released yet (no tag), so I'd say it should be renamed, but yeah Adrián Chaves Fernández (cc'ed here) should probably gives his opinion, since he's the one who did this KF5 porting. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86673 ----------------------------------------------------------- On Oct. 11, 2015, 7:46 p.m., Dāvis Mosāns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125556/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2015, 7:46 p.m.) > > > Review request for KDE Frameworks and Adrián Chaves Fernández. > > > Repository: libmediawiki > > > Description > ------- > > They were generated but wasn't installed. > > > Diffs > ----- > > src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 > > Diff: https://git.reviewboard.kde.org/r/125556/diff/ > > > Testing > ------- > > Compiles and headers are installed. > > > Thanks, > > Dāvis Mosāns > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
