> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. > > Christoph Cullmann wrote: > Done > > Christoph Cullmann wrote: > Lets stall this until the discussion about the dependencies on the > frameworks list is done.
The discussion has ebbed, David, have you some input how to handle that? Make it just optional, add some global switch to ECM to allows to build with "minimal deps" that turns required into optional if possible? Or other solutions? I would really like to have this in to continue with more pressing stuff on fixing on Mac. CC Alex for ECM. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125616/#review86763 ----------------------------------------------------------- On Oct. 13, 2015, 6:32 a.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125616/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 6:32 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Make doctools + wallet optional. > > > Diffs > ----- > > CMakeLists.txt cfea7b2 > src/ioslaves/help/CMakeLists.txt 3f07f31 > src/kpasswdserver/CMakeLists.txt c9f49a5 > > Diff: https://git.reviewboard.kde.org/r/125616/diff/ > > > Testing > ------- > > Still compiles all stuff if all deps are around > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
