----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125673/#review86997 -----------------------------------------------------------
Ship it! I'm no big fan of notifications myself (I certainly hate computers making sounds on popups -- I guess not everyone has the same opinion), but I put that code in because I was basically forking kmessagebox. Looking at KMessageBox these days, it uses a plugin for the notify stuff. So we could either - just remove this - or expose KMessageBoxNotifyInterface * notifyInterface() (currently in kmessagebox_p.h) for others to use as well. As you say however, other dialogs which are not messageboxes have no special code for notifications, so if one really wanted a notification on each dialog they would have to do this more low-level anyway. So yeah. +2. - David Faure On Oct. 17, 2015, 1:23 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125673/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2015, 1:23 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kparts > > > Description > ------- > > KParts uses KNotification to raise some notification for the open or save > dialog. > Given no other framework beside khtml/plasma uses explicit notifications, I > don't see a gain in having this for this one question dialog here, given all > other dialogs > don't do this in all frameworks. > Will avoid one dependency for all thigs using kparts without a loss of > functionality. > If removing is bad, I can make this optional, but I don't really see the gain > in having it. > > > Diffs > ----- > > CMakeLists.txt 6abfd4d > src/CMakeLists.txt 530273d > src/browseropenorsavequestion.cpp e1a9f45 > > Diff: https://git.reviewboard.kde.org/r/125673/diff/ > > > Testing > ------- > > Compiled, worked. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
