----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125688/#review87025 -----------------------------------------------------------
Ship it! Well, I think the notification that your access to the internet (via a proxy) is broken is useful (and this only happens for users in an environment where their sysadmin told them to set up a specific URL as proxy script; so with the notification they can relay the error to their sysadmin). So I agree with making this optional, but not really with the commit log. - David Faure On Oct. 18, 2015, 1:09 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125688/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 1:09 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Make KNotifications dep in KIO (kpac) optional. > > I am not sure if the notifications are at all very useful, given the user > won't understand what they are about in 99% of the cases. > > > Diffs > ----- > > src/kpac/CMakeLists.txt fc6043f > src/kpac/proxyscout.cpp 972dde2 > > Diff: https://git.reviewboard.kde.org/r/125688/diff/ > > > Testing > ------- > > Compiles and run with and without the dep around. > Missed this dep. first as it is only for this subtool :( > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
