----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/ -----------------------------------------------------------
(Updated Oct. 22, 2015, 3:31 p.m.) Review request for KDE Frameworks and Plasma. Changes ------- Use Q_NULLPTR and initialize in cpp Summary (updated) ----------------- Initialize QFunctionPointer to Q_NULLPTR Repository: plasma-framework Description (updated) ------- Need to initialize QFunctionPointer to Q_NULLPTR because otherwise it's used unitialized causing m_eglCreateImageKHR check to pass and crashing plasmashell because of invalid call. Look at xcbWindowToTextureEGL function in src/declarativeimports/core/windowthumbnail.cpp Diffs (updated) ----- src/declarativeimports/core/windowthumbnail.cpp 5a5274e1eacdb9b91ff500e1ebf9046930891ecf Diff: https://git.reviewboard.kde.org/r/125756/diff/ Testing ------- Verified that plasmashell doesn't crash anymore. Thanks, Dāvis Mosāns
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel