> On Oct. 27, 2015, 10:23 p.m., Alex Merry wrote: > > src/core/kprotocolinfo.cpp, lines 121-122 > > <https://git.reviewboard.kde.org/r/125830/diff/1/?file=413023#file413023line121> > > > > I would still rather calculate this information - protocol is the key > > from the iterated map, and exec is (I think) the base name of the file the > > JSON was extracted from. These could be passed in as separate parameters. > > > > exec in particular is a case of easily eliminating a place people could > > make mistakes. It also allows the binaries to be freely renamed (although > > that's not an important feature, really).
You are right ;=) I wanted to do that later anyway, done now. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125830/#review87558 ----------------------------------------------------------- On Oct. 27, 2015, 10:31 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125830/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 10:31 p.m.) > > > Review request for KDE Frameworks, Alex Richardson and David Faure. > > > Repository: kio > > > Description > ------- > > Extends the protocol factory and co. to allow reading of protocol data from > embedded json. > Allows to deploy io slaves without anything else than the io slave itself in > librarypath kf5/kio. > > I changed to factory to ALWAYS fill its cache for any request, as now the > determination which protocols are around is more expensive than just some > directory traversal. > > If this preview is ok, I will do that for all other shipped slaves and update > this request. > > > Diffs > ----- > > src/core/kprotocolinfo.cpp 8a02f7a > src/core/kprotocolinfo_p.h c3dea6b > src/core/kprotocolinfofactory.cpp 29ba8f4 > src/core/kprotocolinfofactory_p.h aa79fc5 > src/ioslaves/http/http.cpp 1727d41 > src/ioslaves/http/http.json PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125830/diff/ > > > Testing > ------- > > http slave still seems to be found and work. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
