----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125904/#review87791 -----------------------------------------------------------
src/kcms/kio/kproxydlg.cpp (line 106) <https://git.reviewboard.kde.org/r/125904/#comment60243> QString() instead of "" src/kcms/kio/kproxydlg.cpp (line 207) <https://git.reviewboard.kde.org/r/125904/#comment60245> remove space between url and ( src/kcms/kio/kproxydlg.cpp (line 294) <https://git.reviewboard.kde.org/r/125904/#comment60244> does that even compile? it should be QStringLiteral("http"), same with the rest. - Aleix Pol Gonzalez On Oct. 31, 2015, 11:55 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125904/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2015, 11:55 p.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Repository: kio > > > Description > ------- > > Currently, if user type a ip address/domain name in socks 5 proxy field, the > saved proxy url in configuration file will start with http:// instead of > socks:// . Same applies to ftp proxy. > > The reason is that KUrlFilter append http scheme to url without scheme. This > patch uses setDefaultUrlScheme to make sure the correct scheme is used. > > Also make necessary change to make sure that loading url configuration will > hide url scheme correctly. > > > Diffs > ----- > > src/kcms/kio/kproxydlg.cpp c8fd0cd > > Diff: https://git.reviewboard.kde.org/r/125904/diff/ > > > Testing > ------- > > Save socks proxy and ftp proxy will result in "ftp://"; and "socks://". > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
