> On Nov. 1, 2015, 11:35 p.m., David Edmundson wrote:
> > I've made https://git.reviewboard.kde.org/r/125915/

back referencing my comment to that review: I think trying to change 
KWindowSystem to not use desktopWidget doesn't solve the problem. KWindowSystem 
is a QWidget based framework. Thus it requires a QApplication.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125905/#review87825
-----------------------------------------------------------


On Nov. 1, 2015, 2:33 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125905/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 2:33 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Ivan Čukić.
> 
> 
> Repository: kactivities
> 
> 
> Description
> -------
> 
> KWindowSystem is QWidget based so needs QApplication or asserts in some 
> situations (when run on unity7 for example)
> 
> 
> Diffs
> -----
> 
>   src/service/Application.h 387d4d7 
>   src/service/Application.cpp ec74daa 
> 
> Diff: https://git.reviewboard.kde.org/r/125905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to