> On nov. 3, 2015, 10:21 p.m., Alex Merry wrote: > > src/kdeui/kpixmapcache.cpp, line 132 > > <https://git.reviewboard.kde.org/r/125938/diff/1/?file=414678#file414678line132> > > > > Why time_t here, and quint32 further down? If anything, I'd expect it > > to be the other way around - this is the one that's important to be fixed.
Because this is exactly how the code of kdelibs4 was and i have decided to not get creative with a code that works, last time someone got creative with this code broke it :D - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/#review87970 ----------------------------------------------------------- On nov. 3, 2015, 8:53 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125938/ > ----------------------------------------------------------- > > (Updated nov. 3, 2015, 8:53 p.m.) > > > Review request for KDE Frameworks and Michael Pyne. > > > Repository: kdelibs4support > > > Description > ------- > > Need to use POD types. > > > Diffs > ----- > > src/kdeui/kpixmapcache.cpp c16384d > > Diff: https://git.reviewboard.kde.org/r/125938/diff/ > > > Testing > ------- > > kigo doesn't crash on startup anymore. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel