----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review88070 -----------------------------------------------------------
I don't know enough about the module, so I don't know about the exact case, but usually it's good to develop such API outside then when it stabilizes merge to the framework, I'd say. Otherwise changes in the API will be very hard. - Aleix Pol Gonzalez On Nov. 5, 2015, 8:57 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125965/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 8:57 p.m.) > > > Review request for KDE Frameworks and John Layt. > > > Repository: kholidays > > > Description > ------- > > For now it contains just the model of holiday regions > which will be used in the Plasma calendar events > configuration. > > > Diffs > ----- > > CMakeLists.txt e8b7970 > src/CMakeLists.txt c067b6c > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/holidayregionsmodel.h PRE-CREATION > src/declarative/holidayregionsmodel.cpp PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.h PRE-CREATION > src/declarative/kholidaysdeclarativeplugin.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125965/diff/ > > > Testing > ------- > > Applet configuration contains proper list of available > holiday regions. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
