----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125969/ -----------------------------------------------------------
(Updated Nov. 6, 2015, 4 p.m.) Review request for KDE Frameworks and Alex Merry. Changes ------- now displayEnvVarName_c() returns const char* and displayEnvVarName() is wrapping it into a QByteArray Repository: kinit Description ------- this patch fixes two coverity issues ranked 'outstanding': https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24554334&mergedDefectId=258481 https://scan5.coverity.com/reports.htm#v39099/p10103/fileInstanceId=82663767&defectInstanceId=24557588&mergedDefectId=258474 and also does small string-related optimization by eliminating redundant mallocs done by QByteArray ctor Diffs (updated) ----- src/kdeinit/kinit.cpp 9e775b6 Diff: https://git.reviewboard.kde.org/r/125969/diff/ Testing ------- compiles fine Thanks, Nick Shaforostoff
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel