----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126004/#review88189 -----------------------------------------------------------
Ship it! Good stuff! - Sebastian Kügler On Nov. 9, 2015, 11:21 a.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126004/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 11:21 a.m.) > > > Review request for KDE Frameworks. > > > Repository: breeze-icons > > > Description > ------- > > to ensure greatest possible compatibility icon names are often symlinked > to other names. unfortunately symlinks can easily break without anyone > noticing. the symlinktest is supposed to prevent this by iterating the > entire project tree's symlinks and checking if they are actually pointing > to something. > additionally symlinks must not point to out-of-tree files. even if valid. > > > Diffs > ----- > > COPYING.LIB PRE-CREATION > autotests/CMakeLists.txt PRE-CREATION > CMakeLists.txt 130b3346a6dc6dd86e65cc68bac6ccca19edf772 > autotests/symlinktest.cpp PRE-CREATION > autotests/testdata.h.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126004/diff/ > > > Testing > ------- > > ctest with both conditions true and false (master actually doesn't pass right > now :() > > > Thanks, > > Harald Sitter > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
