----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126056/#review88339 -----------------------------------------------------------
Ship it! This could do with more work than just this - a bunch of the stuff in this file is a holdover from when it was copied from the oxygen-icons module. At the least, the top three lines in the file (cmake_minimum_required to the set(CMAKE_MODULE_PATH)) should go. I'd be tempted to write the whole file again from scratch, though - I'm pretty sure the bit distinguishing WIN32 from other systems is unnecessary, there are no ``*.sh`` files to exclude from the install(), and install() doesn't need full paths anyway. That said, if you just want to commit what you have here, that's fine, too. - Alex Merry On Nov. 13, 2015, 6:05 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126056/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 6:05 p.m.) > > > Review request for KDE Frameworks and Uri Herrera. > > > Repository: breeze-icons > > > Description > ------- > > It was previously hard-coded to prefix/share which is not helpful on a > multiarch layout, where the prefix might be something like /usr/${arch} > but arch independent files should still go into /usr/share. > > > Diffs > ----- > > icons-dark/CMakeLists.txt f039db19e1df89f62a33dc323cf0b8344d9b33fd > icons/CMakeLists.txt 6c6e3b7efb6ca1490ed52356beaf06c4e181fee0 > > Diff: https://git.reviewboard.kde.org/r/126056/diff/ > > > Testing > ------- > > Icons get installed into the desired location. > > > Thanks, > > Heiko Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel