> On Nov. 17, 2015, 9:43 a.m., Chusslove Illich wrote: > > Could you also document the usage in docs/programmers-guide.md (section > > #link_cat)? I'm not much into QML, so it would help me understand the > > implications of the usage. > > > > It seems to me other three series of calls (xi18n*, ki18n*, kxi18n*) should > > be made available as well. > > Aleix Pol Gonzalez wrote: > I don't think we want the `k*i18n*` version of the calls, as they return > KLocalizedString and we probably don't need to deal with it from QML. > > Regarding `xi18n*`, I see that we have counter-parts for every of the > `i18n*` calls. Could you explain a bit what does it do differently? Is it to > support the xml-like markup? > > Chusslove Illich wrote: > KLocalizedString exposes the lower-level interface, and more possible > argument combinations, so in principle k*i18n* can be useful even in > one-liners ending with .toString(). Is there any particular reason not to > have it? > > Yes, xi18n* are for ki18n's own XML markup. So if someone likes to use > xi18n* generally in the whole program, he should want to use it in QML files > as well.
I added xi18n*. Regarding KLocalizedString, I would wait and assess how we want it to be used later on. It largely relies on type system overloads and I'm not sure how well Qt would be able to bind to it. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88459 ----------------------------------------------------------- On Nov. 16, 2015, 3:55 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126087/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 3:55 p.m.) > > > Review request for KDE Frameworks, Chusslove Illich and Marco Martin. > > > Repository: ki18n > > > Description > ------- > > The only way to use `i18n*()` so far in QML is by depending on all > KDeclarative. This patch moves the necessary bits there so it can be adopted > by an application or framework just by offering the needed bits within KI18n. > This is done by offering an object with methods that map to the `i18n*()` C++ > counter-parts. > > > Diffs > ----- > > src/klocalizedcontext.cpp PRE-CREATION > src/CMakeLists.txt 818595e > src/klocalizedcontext.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126087/diff/ > > > Testing > ------- > > Ported KDeclarative, everything still seems to work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
