> On Nov. 19, 2015, 5:21 p.m., Marco Martin wrote: > > so let's go for that and then add the import with the singleton as well, if > > is okay for framework maintainer are fine with the qtqml dependency.. but > > they should be as the "everything in kdeclarative" situation has to be > > solved (maybe optional dep at build time?) > > Aleix Pol Gonzalez wrote: > Are you sure you want to consider Qt5::Qml as an optional dependency? I > don't have a problem with it, but it seems odd as a first step. > > Personally I'd like to propose it as is and if there's a reason not to > have it, then consider it.
For completion, at the moment the Qml dependency is only on the test. The full Qml dependency we'd get it if/when we do the qml runtime plugin, which I'd introduce in a later patch. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/#review88612 ----------------------------------------------------------- On Nov. 19, 2015, 5 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126087/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 5 p.m.) > > > Review request for KDE Frameworks, Chusslove Illich and Marco Martin. > > > Repository: ki18n > > > Description > ------- > > The only way to use `i18n*()` so far in QML is by depending on all > KDeclarative. This patch moves the necessary bits there so it can be adopted > by an application or framework just by offering the needed bits within KI18n. > This is done by offering an object with methods that map to the `i18n*()` C++ > counter-parts. > > > Diffs > ----- > > autotests/CMakeLists.txt 1cf0f7a > autotests/ki18ndeclarativetest.cpp PRE-CREATION > autotests/test.qml PRE-CREATION > docs/programmers-guide.md 13a5f9d > src/CMakeLists.txt 818595e > src/klocalizedcontext.h PRE-CREATION > src/klocalizedcontext.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126087/diff/ > > > Testing > ------- > > Ported KDeclarative, everything still seems to work. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
