----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126131/#review88703 -----------------------------------------------------------
are you sure it means that? I mean I did read the documentation when writing that code and did deliberately wrote the code like that. So I'm a little bit surprised that I got it exactly the other way around. - Martin Gräßlin On Nov. 22, 2015, 2:57 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126131/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2015, 2:57 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > The QSGTextures are created with > > window()->createTextureFromId(m_texture, QSize(w,h), > QuickWindow::TextureOwnsGLTexture)); > > this means we don't want to be deleting textures ourselves too, it will > be deleted when we delete the QSGTexture, which is a scoped pointer > inside our QSGNode. > > BUG: 355644 > REVIEW: > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp > 2b09657e8ce6bd1cca1acc323d5955b2f1a1efb2 > > Diff: https://git.reviewboard.kde.org/r/126131/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
