> On Nov. 25, 2015, 9:30 p.m., David Faure wrote: > > autotests/CMakeLists.txt, line 44 > > <https://git.reviewboard.kde.org/r/125941/diff/4/?file=418276#file418276line44> > > > > sorry I just realized something else: these calls to "tar" will break > > on Windows. > > > > I would suggest to either > > 1) add small archives to git, or > > 2) create those from code using KArchive > > > > Of course there's also easy option 3: find_program(TAR tar) > > if (Qt5Network_FOUND AND TAR) > > ... > > and then using ${TAR} instead of tar, to be consistent.
Are you sure? Isn't `cmake -E` supposed to give a list of commands which will be available in any platform? From `man cmake`: -E CMake command mode. For true platform independence, CMake provides a list of commands that can be used on all systems. - Romário ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review88850 ----------------------------------------------------------- On Nov. 25, 2015, 9:19 p.m., Romário Rios wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125941/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 9:19 p.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure. > > > Repository: karchive > > > Description > ------- > > I recently noticed that using KTar with KCompressionDevice and QNetworkReply > did not work, so I'm adding some tests to confirm that > > > Diffs > ----- > > autotests/CMakeLists.txt 1b2e819 > autotests/kcompressiondevicetest.h PRE-CREATION > autotests/kcompressiondevicetest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125941/diff/ > > > Testing > ------- > > The tests run and show that KCompressionDevice works properly with QBuffer > when used with KTar > > > Thanks, > > Romário Rios > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel