> On Nov. 28, 2015, 8:10 p.m., Jarosław Staniek wrote: > > Hi, I see one regression. > > Before this change I had "MimeType" field. And I've been using this field. > > > > Now I miss miss this field and have "KPlugin/MimeTypes" field. This means > > plugin error if KF5 5.16.x is installed. I cannot fix my sources: if I do > > users of KF5 <= 5.15.x will get equivalent error. > > Alex Richardson wrote: > Hmm I hadn't thought of that. Sorry for causing a regression. I assume > you are using kcoreaddons_desktop_to_json() to generate the JSON file > otherwise this issue shouldn't appear > > I see a few ways of working around this in the sources: > > - Depend on KF >= 5.16 (easiest but unlikely to be possible) > - Change MimeType= into X-MyApp-MimeType= and then read that field > - You could use JSON files directly instead of .desktop files > - a) add the MimeType string to the root object > - b) use the 5.16 JSON with a string list and use > KPluginMetaData::readStringList(rawData()["KPlugin"], > QStringLiteral("MimeTypes")); for KF <= 5.16 > > Jarosław Staniek wrote: > Thanks for the quick reply with options. > > Yes, I am using kcoreaddons_desktop_to_json(). > > The error is at > https://build.kde.org/job/kdb%20master%20kf5-qt5/36/PLATFORM=Linux,compiler=gcc/testReport/%28root%29/TestSuite/ConnectionTest/ > I did not notice before because CI does not send notification for my > repos (no idea how to enable them, reported to Sysadmin). > > Yes, I plan to switch to JSON files entirely, so now I have extra reason. > > Do you think the regression is worth removing or instead some statement > can be made in the docs for kcoreaddons_desktop_to_json() about what are the > guaranteed contents of the JSON?
PS: KPluginMetaData::mimeTypes() is advertised for use but is it good habit to depend on KF 5.16 just for that? Personally I am not using it. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125527/#review88915 ----------------------------------------------------------- On Oct. 6, 2015, 1:42 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125527/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 1:42 p.m.) > > > Review request for KDE Frameworks, David Faure and Sebastian Kügler. > > > Repository: kcoreaddons > > > Description > ------- > > When loading a .desktop file this will parse the XDG MimeType= key > > Contrary to KService we don't merge these with ServiceTypes but rather > have them as a separate property. > > REVIEW: 125261 > > KPluginMetaData: Warn when a list entry is not a JSON list > > We still convert single values to a list with one entry but now also > output a warning. > > REVIEW: 125261 > > > Diffs > ----- > > autotests/data/fakeplugin.desktop 30ff9a98d4587507620f70e3c271456877ab1812 > autotests/kpluginmetadatatest.cpp 3af5e1b842b0bc231a5ac001112e141f751d2ff5 > src/lib/plugin/desktopfileparser.h 98d47ddf0f877c4a25928026b3d5fe169cfc9e75 > src/lib/plugin/desktopfileparser.cpp > 0b03eb154deb58840c91c12658780c0d492b593c > src/lib/plugin/kpluginmetadata.h 183b0d0583259f7ed74e97858a68c5c388fd0a9a > src/lib/plugin/kpluginmetadata.cpp b13d6dd52827cc03d9473600aa4d2bab8a95a1d4 > > Diff: https://git.reviewboard.kde.org/r/125527/diff/ > > > Testing > ------- > > This is the same as review 125261 but for some reason I kept getting a > internal server error when I tried to update it. > > > Used this for a WIP port of Okular to new Plugin loading. Could also be used > by KDevelop instead of the custom X-KDevelop-SupportedMimeTypes property > > Requires https://git.reviewboard.kde.org/r/125263/ to ensure that there are > no regressions > > > Thanks, > > Alex Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel