----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126222/#review89111 -----------------------------------------------------------
src/kratingwidget.cpp (line 181) <https://git.reviewboard.kde.org/r/126222/#comment60992> Code style: move the bracket at the end of this line to the next line. - Lamarque Souza On Dec. 3, 2015, 10:19 a.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126222/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 10:19 a.m.) > > > Review request for KDE Frameworks, David Faure and Lamarque Souza. > > > Repository: kwidgetsaddons > > > Description > ------- > > Refactor the rating calculation: > 1. Disable feature introduced in bug 171343 when halfSteps is enabled. > 2. Merge the two pieces of code, and try to make it clearer and simpler. > 3. make hover 0 star also show visual effect. > > > Diffs > ----- > > src/kratingpainter.cpp 1a4378a > src/kratingwidget.cpp d0d2903 > > Diff: https://git.reviewboard.kde.org/r/126222/diff/ > > > Testing > ------- > > Current rating is 0, hover on the 1st star, 1 star lights up, click on 1st > star, rating becomes 2. > > Current rating is 2. hover on the 1st star, half star lights up, click on 1st > star, rating becomes 1. > > Current rating is 1/2. move mouse to the left most edge, star's color becomes > lighter. Click and rating becomes 0. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
