----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ -----------------------------------------------------------
(Updated Gru 15, 2015, 12:34 po poĊudniu) Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes ------- Fixed issue with MSVC not supporting multiline QStringLiteral-s. Repository: ki18n Description (updated) ------- Fixed `warning: KuitSetup has dtor, copy-ctor but not copy-assignment [-Wclazy-rule-of-three]` Fixed `warning: Reserve candidate [-Wclazy-reserve-candidates]` Fixed `warning: Use QVariant::toFoo() instead of QVariant::value<Foo>() [-Wclazy-variant-sanitizer]` Fixed `warning: Use midRef() instead [-Wclazy-qstring-ref]` Fixed `warning: Pass small and trivially-copyable type by value (const class QChar &) [-Wclazy-foreach]` Fixed `warning: QString::fromLatin1() being passed a literal [-Wclazy-qstring-uneeded-heap-allocations]` Fixed `warning: QString(const char*) being called [-Wclazy-qstring-uneeded-heap-allocations]` Fixed `warning: QString(QLatin1String) being called [-Wclazy-qstring-uneeded-heap-allocations]` Changed `QLatin1String`-s to `char[]` when writteing to warning. Changed to `QStringLitera`-s in some lines, where Clazy isn't warning. Diffs (updated) ----- src/common_helpers.cpp dad7f84 src/kcatalog.cpp 7711e9b src/klocalizedcontext.cpp 3bc42dd src/klocalizedstring.cpp 69950d2 src/ktranscript.cpp 04dda66 src/kuitmarkup.h d110ca3 src/kuitmarkup.cpp 02b891a Diff: https://git.reviewboard.kde.org/r/126350/diff/ Testing ------- Automated tests 1,3 and 4 passing. Test 2 fails on my system both: after changes and before. Thanks, Artur Puzio
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
