----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/#review89553 -----------------------------------------------------------
An autotest would be nice, and I think the ASSERT is too aggressive. src/lib/plugin/kpluginmetadata.cpp (line 68) <https://git.reviewboard.kde.org/r/126366/#comment61279> I don't like the assert here. It may be third party data, and we're crashing the application then? - Sebastian Kügler On Dec. 15, 2015, 3:04 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126366/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 3:04 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Loads the json file upon construction. Simplifies adoption of json metadata > files for KPackage. > > > Diffs > ----- > > src/lib/plugin/kpluginmetadata.h a91b94a > src/lib/plugin/kpluginmetadata.cpp 3674360 > > Diff: https://git.reviewboard.kde.org/r/126366/diff/ > > > Testing > ------- > > Tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel