> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > <https://git.reviewboard.kde.org/r/125869/diff/1/?file=413338#file413338line6> > > > > That doesn't look very English to me ;) > > > > The original is: > > > > ExtraNames=Original Path,Deletion Date > > > > But this shows a problem: missing support for translating this field. > > We didn't realize there was a translatable field in these files. Please add > > support for translations, like was done for other json files (talk to e.g. > > Luigi Toscano). > > Christoph Cullmann wrote: > Hmm, then we have a problem: We can no longer convert the stuff and > remove the .protocol files, or? > > Christoph Cullmann wrote: > Ok, did read up a bit, ExtraNames seems to be the only translated thing > (at least if I read KProtocolInfo docs the right way). > Can do the same trick as desktop2json does for that. Seems not that hard. > But then we need CMake stuff for it, or? To convert on the fly to have > translations using the .protocol files like we have ATM in the .desktop files > for the plugin stuff. > > David Faure wrote: > I don't think you're looking in the right direction. AFAIK there is > support for translating json files directly in l10n (json -> po -> json) > these days. As I said, please ask Luigi or maybe Albert. > > Christoph Cullmann wrote: > Ok ;=) > > Christoph Cullmann wrote: > CC Luigi here, too. > I looked again at what we have btw. in the other frameworks and I nowhere > really found any json -> po and back way, but that doesn't mean its not there > ;=) > > David Faure wrote: > I'm pretty sure this is all done in the l10n module, not in the other > frameworks. > > Christoph Cullmann wrote: > Any idea who else to ping? With that patch at least the shipped IO slaves > work perfect on Win/Lin without any hacks, I would really like to get that > in. Some .protocol -> json -> ... translation stuff should be easy to do, but > for translating the list inside JSON I am a bit lost ;=) > > Luigi Toscano wrote: > Generically, the i18n (or l10n, never rememeber) group. This specific > code (translation of json) was done by Burkhard Lueck. Now, I was out for > vacation and business, so give some time. It's too late anyway from the next > framework version, so there is one month.
Hi, can I commit my changes to the converted + the i18n aware reading? Will do a new review request for the actual conversion of the remaining .protocol files afterwards. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review87721 ----------------------------------------------------------- On Dec. 28, 2015, 7:25 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125869/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 7:25 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Alex Richardson, David > Faure, and Luigi Toscano. > > > Repository: kio > > > Description > ------- > > Convert all io slave .protocol data to json and embed it. > Allows easier deployment of the slaves. > > > Diffs > ----- > > src/core/kprotocolinfo.cpp 7bfb9ad > src/protocoltojson/main.cpp 05b9364 > > Diff: https://git.reviewboard.kde.org/r/125869/diff/ > > > Testing > ------- > > Tests still work (one needed patching, as the exec line contains now the full > path). > > Correction: Somehow the ./autotests/jobtest test is unstable for me here, > sometimes it works, sometimes not :/ but even without this change. > > > File Attachments > ---------------- > > trash.json > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/28/6ab2cd95-b0bd-4347-80f2-6f753fa50425__trash.json > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
