----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90395 -----------------------------------------------------------
src/platforms/xcb/kwindowsystem.cpp (line 59) <https://git.reviewboard.kde.org/r/126403/#comment61834> move into the if() to save some work if isDirty==false? src/platforms/xcb/kwindowsystem.cpp (line 890) <https://git.reviewboard.kde.org/r/126403/#comment61847> isn't that "return displayGeometry()?" If not, then at least something like QRect(QPoint(0,0), displayGeometry().size()) (encapsulated in a convenience function) would avoid calling displayGeometry() twice. - David Faure On Dec. 17, 2015, 3:38 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126403/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 3:38 p.m.) > > > Review request for KDE Frameworks, kwin and Albert Astals Cid. > > > Bugs: 354811 > https://bugs.kde.org/show_bug.cgi?id=354811 > > > Repository: kwindowsystem > > > Description > ------- > > summarized, alternative to https://git.reviewboard.kde.org/r/126397/ > > NOTICE: this compiles but is otherwise *completely* untested! > > > Diffs > ----- > > src/platforms/xcb/kwindowsystem.cpp 9d28704 > > Diff: https://git.reviewboard.kde.org/r/126403/diff/ > > > Testing > ------- > > no, not the least. esp. not on the bug. > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel