> On Jan. 1, 2016, 5:04 p.m., David Faure wrote: > > Ship It!
David, could you have a look to RR 126505, before I ship this one? (btw, the 5.18 tagging is today?) - Elvis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126426/#review90400 ----------------------------------------------------------- On Dec. 24, 2015, 5:55 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126426/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 5:55 p.m.) > > > Review request for KDE Frameworks, KDE Usability and Valentin Rusu. > > > Repository: kwallet > > > Description > ------- > > Set a "background warning color" when password and its verification do not > match, in the KNewPasswordDialog run by kwalletd. > This adds a new dependency (needed to avoid hardcoding colors), but I think > is a nice feature to have. > See RR 125619 for a screenshot: > https://git.reviewboard.kde.org/r/125619/file/2515/ > > > Diffs > ----- > > src/runtime/kwalletd/CMakeLists.txt > ba9e7ba508c74fed1d8101496583061245640aa7 > src/runtime/kwalletd/kwalletd.cpp 6da97031e13240a9630cfa7e0dc3cf42575819c4 > > Diff: https://git.reviewboard.kde.org/r/126426/diff/ > > > Testing > ------- > > Compiles fine. > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel