> On Gen. 6, 2016, 8:33 a.m., David Faure wrote: > > src/xslt_kde.cpp, line 17 > > <https://git.reviewboard.kde.org/r/126648/diff/1/?file=428563#file428563line17> > > > > I would suggest to add a qWarning() under this line, to warn at runtime > > in case this is ever called in a non-karchive build.
Thanks; I'm going to update the patch for reference, then push it after the release of Frameworks 5.18. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126648/#review90682 ----------------------------------------------------------- On Gen. 6, 2016, 1:58 a.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126648/ > ----------------------------------------------------------- > > (Updated Gen. 6, 2016, 1:58 a.m.) > > > Review request for Build System, KDE Frameworks, Alex Merry, and David Faure. > > > Repository: kdoctools > > > Description > ------- > > Most of the code was already prepared to compile without the KArchive > dependency (including the MEINPROC_NO_KARCHIVE flag). > This mode should be only enabled on KDE infrastructure, as the compressed > cache (the only added feature coming from KArchive) is not used by the > generator of the documentation website. > A warning is printed when the mode is enabled. > The saveToCache function is preserved, even if without code, to minimize the > changes required. > > > Diffs > ----- > > CMakeLists.txt 2ec3027 > src/CMakeLists.txt 136fbfb > src/xslt_kde.cpp 7069a28 > > Diff: https://git.reviewboard.kde.org/r/126648/diff/ > > > Testing > ------- > > Normal compilation, compilation with MEINPROC_NO_KARCHIVE=ON > > > Thanks, > > Luigi Toscano > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
