-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126661/#review90796
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 7, 2016, 5:40 p.m., Mihail Ivchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126661/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 5:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpackage
> 
> 
> Description
> -------
> 
> QLatin1String -> QStringLiteral where it makes sense.
> Raw string literals -> QStringLiteral and QLatin1String (where possible).
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -----
> 
>   src/kpackage/package.cpp d210015 
>   src/kpackage/packageloader.cpp 9f7dd48 
>   src/kpackage/private/packagejobthread.cpp b7f5d2d 
>   src/kpackage/private/packages.cpp 3de80a0 
>   src/kpackagetool/kpackagetool.cpp 61a0043 
>   src/kpackagetool/main.cpp 453f3e8 
> 
> Diff: https://git.reviewboard.kde.org/r/126661/diff/
> 
> 
> Testing
> -------
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to