> On Jan. 10, 2016, 9:55 a.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 61 > > <https://git.reviewboard.kde.org/r/126403/diff/2/?file=428224#file428224line61> > > > > How does this work? I see code iterating through that list, but I don't > > see code adding to the list in the first place. Dead code? Unfinished code?
Forgot to add them to the list ... > On Jan. 10, 2016, 9:55 a.m., David Faure wrote: > > src/platforms/xcb/kwindowsystem.cpp, line 69 > > <https://git.reviewboard.kde.org/r/126403/diff/2/?file=428224#file428224line69> > > > > This reads weird, (casting from GuiApp to GuiApp), but in fact it's > > because there's no QGuiApplication::instance, it's > > QCoreApplication::instance, I would suggest to use that to make this more > > readable. > > > > qApp should work too. It expands to exactly that, when #including > > QGuiApplication. I've no idea how that ended up there. Seriously not. On Jan. 10, 2016, 9:55 a.m., Thomas Lübking wrote: > > The commit log also needs to be updated, assuming it's still equal to the > > description that is visible in ReviewBoard. No, it's just "get rid of QApplication dependency" and commit hooks. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126403/#review90834 ----------------------------------------------------------- On Jan. 6, 2016, 5:34 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126403/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 5:34 p.m.) > > > Review request for KDE Frameworks, kwin and Albert Astals Cid. > > > Bugs: 354811 > https://bugs.kde.org/show_bug.cgi?id=354811 > > > Repository: kwindowsystem > > > Description > ------- > > summarized, alternative to https://git.reviewboard.kde.org/r/126397/ > > NOTICE: this compiles but is otherwise *completely* untested! > > > Diffs > ----- > > src/platforms/xcb/kwindowsystem.cpp 9d28704 > > Diff: https://git.reviewboard.kde.org/r/126403/diff/ > > > Testing > ------- > > Albert performed a successful test on the bug. > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
