> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote: > > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47 > > <https://git.reviewboard.kde.org/r/126735/diff/2/?file=430620#file430620line47> > > > > QStringLiteral with multiple string initializers does not work on > > Windows. All places without arguments could use QLatin1String. > > > > There are multiple cases with the same issue in this review. Clazy > > should be fixed to not suggest this change... > > Kåre Särs wrote: > +1 Good to go from my point of view :) I'll let Aleix give the Shipit. > > Aleix Pol Gonzalez wrote: > Actually it has, Andrey update your clazy ;). > > ``` > commit 04a6c6665e73da087cec7d66039830d2932305f7 > Author: Sergio Martins <smart...@kde.org> > Date: Thu Jan 14 10:23:06 2016 +0000 > > qstring-uneeded-heap-allocations: Rename msvc-compat to no-msvc-compat > > Meaning msvc-compat is the default and if you don't want it you > should: > export > CLAZY_EXTRA_OPTIONS="qstring-uneeded-heap-allocations-no-msvc-compat" > > Helps stopping annoying our windows friends. > > Ignoring multi-string literals is not implemented yet, only ignoring > list initialization. > > CCBUG: 357966 > ``` > > David Faure wrote: > "update your clazy" is not a helpful suggestion given the line "Ignoring > multi-string literals is not implemented yet".
But now just a little bit later, Sergio has fixed also the multi-string issue :) https://bugs.kde.org/show_bug.cgi?id=357966 Git commit 9c1458765dbdad21739cbe2b9154667657d2352e by Sergio Martins. Committed on 14/01/2016 at 23:49. Pushed by smartins into branch 'master'. qstring-uneeded-heap-allocations: Improve msvc compat Now we don't warn when using multi token literals like: QString s = "foo" "bar"; - Kåre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126735/#review91051 ----------------------------------------------------------- On Jan. 14, 2016, 11:16 p.m., Andrey Cygankov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126735/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 11:16 p.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Repository: kitemmodels > > > Description > ------- > > Fixed most Clazy warnings in KItemModels. > > > Diffs > ----- > > autotests/kconcatenaterowsproxymodeltest.cpp 0a2f794 > autotests/kextracolumnsproxymodeltest.cpp 015ea65 > autotests/krearrangecolumnsproxymodeltest.cpp 70e6ea9 > autotests/krecursivefilterproxymodeltest.cpp 8c7c65e > autotests/kselectionproxymodeltest.cpp ac3d324 > autotests/proxymodeltestsuite/dynamictreemodel.cpp d5a12e7 > autotests/proxymodeltestsuite/dynamictreewidget.cpp 5a0462b > autotests/proxymodeltestsuite/modelcommander.cpp 8311e5b > autotests/proxymodeltestsuite/modelspy.cpp bb8e520 > autotests/proxymodeltestsuite/proxymodeltest.cpp dd596c6 > src/kconcatenaterowsproxymodel.cpp 074fcd3 > src/kselectionproxymodel.cpp 4d7af29 > tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp 1e01ae3 > tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp a0493c2 > tests/proxymodeltestapp/breadcrumbswidget.cpp d583856 > tests/proxymodeltestapp/checkablewidget.cpp d51458a > tests/proxymodeltestapp/descendantpmwidget.cpp 39bd062 > tests/proxymodeltestapp/kidentityproxymodelwidget.cpp 0150c70 > tests/proxymodeltestapp/kreparentingproxymodel.cpp e79392c > tests/proxymodeltestapp/lessthanwidget.cpp 7af3c1c > tests/proxymodeltestapp/proxyitemselectionwidget.cpp e075dbf > tests/proxymodeltestapp/reparentingpmwidget.cpp 2593732 > tests/proxymodeltestapp/selectioninqmlwidget.cpp 68e1d78 > tests/proxymodeltestapp/selectionpmwidget.cpp f5b353a > > Diff: https://git.reviewboard.kde.org/r/126735/diff/ > > > Testing > ------- > > Build without errors. > Tests passed. > > > Thanks, > > Andrey Cygankov > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel