----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127094/#review92479 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2016, 4:26 a.m., Michael Pyne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127094/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 4:26 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 359485 > https://bugs.kde.org/show_bug.cgi?id=359485 > > > Repository: kcoreaddons > > > Description > ------- > > A bug reporter notes that KRandom reads 16K from /dev/urandom when seeding > its RNG (which is just the libc RNG). This is because we simply use QFile, > which buffers by default, the fix is to avoid buffering the output of this > special file. > > While the effect of reading the extra 16K-4 bytes should not be severe (I > would not expect a modern OS to return bytes that utilize raw entropy) > there's no reason to do it wrong either. > > > Diffs > ----- > > src/lib/randomness/krandom.cpp da78388 > > Diff: https://git.reviewboard.kde.org/r/127094/diff/ > > > Testing > ------- > > Compiles and installs, applications still seem to run. > > > Thanks, > > Michael Pyne > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
