----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127117/ -----------------------------------------------------------
(Updated Feb. 23, 2016, 8:54 p.m.) Review request for KDE Frameworks and KDEPIM. Changes ------- Add a test Repository: kpeople Description ------- For filtering multiple properties the logic needs to be OR rather than AND. For example in Plasma Mobile, one can start a conversation either with a phonenumber contact or IM contact, so both properties need to be requested. But with AND matching it won't return anything (or only those contacts that have both and user merged them). Diffs (updated) ----- autotests/fakecontactsource.cpp b227723 autotests/personsproxymodeltest.cpp 1143e5f src/personssortfilterproxymodel.cpp b011cbd Diff: https://git.reviewboard.kde.org/r/127117/diff/ Testing ------- I get both phonenumber and IM contacts in Plasma Mobile Thanks, Martin Klapetek
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
