----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127158/#review92735 -----------------------------------------------------------
I think the very first thing you should do is divide the whole thing into multiple patches, and thus 3 review requests. Discard this one and file 3 new ones. The three should be - one that adds all the write functionality, one that adds the external reader, and one that adds the external writer. In any case, as they're three different major features, you'll have to commit them in three different commits anyway. - Boudhayan Gupta On Feb. 24, 2016, 3:33 a.m., Varun Joshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127158/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 3:33 a.m.) > > > Review request for Baloo, KDE Frameworks and Vishesh Handa. > > > Repository: kfilemetadata > > > Description > ------- > > Builds upon Boudhyan Gupta's work on external extractors, creating a process > that runs a script that extracts/writes data, accepting input and producing > an output (JSON-formatted) via stdin/stdout. > > Adds Writer, WriterData, WriterPlugin and WriterCollection classes, analogous > to the Extractor classes. The only notable difference is that consumer > applications will be able to use WriteData (analogous to ExtractionResult) > without subclassing it. > > Adds ExternalWriter and ExternalExtractor classes. These handle input/output > and communication with the external plugins. > > > Diffs > ----- > > README.md 19b1a26a241e6a35c636aaf8162afe762018f073 > autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 > autotests/taglibwritertest.h PRE-CREATION > autotests/taglibwritertest.cpp PRE-CREATION > src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 > src/config-kfilemetadata.h.in PRE-CREATION > src/externalextractor.h PRE-CREATION > src/externalextractor.cpp PRE-CREATION > src/externalwriter.h PRE-CREATION > src/externalwriter.cpp PRE-CREATION > src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e > src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401 > src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250 > src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77 > src/extractors/externalextractors/CMakeLists.txt PRE-CREATION > src/extractors/externalextractors/exampleextractor/main.py PRE-CREATION > src/extractors/externalextractors/exampleextractor/manifest.json > PRE-CREATION > src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION > src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION > src/writedata.h PRE-CREATION > src/writedata.cpp PRE-CREATION > src/writer.h PRE-CREATION > src/writer.cpp PRE-CREATION > src/writer_p.h PRE-CREATION > src/writercollection.h PRE-CREATION > src/writercollection.cpp PRE-CREATION > src/writerplugin.h PRE-CREATION > src/writerplugin.cpp PRE-CREATION > src/writers/CMakeLists.txt PRE-CREATION > src/writers/externalwriters/CMakeLists.txt PRE-CREATION > src/writers/externalwriters/pdfwriter/main.py PRE-CREATION > src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION > src/writers/taglibwriter.h PRE-CREATION > src/writers/taglibwriter.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127158/diff/ > > > Testing > ------- > > Created a sample PDF reader and extractor in Python, both of which work > successfully. > > > Thanks, > > Varun Joshi > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
