----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ -----------------------------------------------------------
(Updated Feb. 28, 2016, 1:18 a.m.) Review request for KDE Frameworks, Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin. Changes ------- Ah, it's really hard to make the test adapts custom path for icon, because KIconTheme::iconPath is used directly in icon item. Also make the test not depending on breeze icon theme by adding a konversation icon to the test-theme used here. BTW, breeze plasma theme name is "default" not "breeze". Repository: plasma-framework Description ------- Well.. the bug should be obvious: 1. QString iconPath overrides the iconPath in a higher scope. introduced in https://git.reviewboard.kde.org/r/126168/ 2. iconPath not assigned, also introduced in https://git.reviewboard.kde.org/r/126168/ 3. svgz -> svg?? introduced in https://git.reviewboard.kde.org/r/126557/ Diffs (updated) ----- autotests/data/bug359388/hicolor/22x22/apps/bug359388.svg PRE-CREATION autotests/data/icons/hicolor/22x22/apps/bug359388.svg 8739af5 autotests/data/icons/test-theme/apps/22/tst-plasma-framework-test-icon.svg PRE-CREATION autotests/data/icons/test-theme/apps/32/tst-plasma-framework-test-icon.svg PRE-CREATION autotests/data/icons/test-theme/apps/48/konversation.svg PRE-CREATION autotests/data/icons/test-theme/index.theme PRE-CREATION autotests/iconitemtest.h 9fd3063 autotests/iconitemtest.cpp f675465 src/declarativeimports/core/iconitem.cpp c65a9a7 Diff: https://git.reviewboard.kde.org/r/127201/diff/ Testing ------- tested with qmlscene with Plasma.IconItem. Thanks, Xuetian Weng
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
