----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127214/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- * Unused variables * Unused code * Unused arguments * Unnecessarily complex code * Initialization order * Duplicated properties It would be _very_ good if we could get rid of Plasma::Package usage within Plasma Framework. I'm quite confident most of these warnings would have been fixed already if it wasn't because we're flooded with deprecated API usage warnings. Diffs ----- autotests/pluginloadertest.cpp b75dd03 src/declarativeimports/calendar/daysmodel.cpp 1faf43b src/declarativeimports/calendar/eventpluginsmanager.cpp 343d586 src/declarativeimports/core/quicktheme.h b8017d2 src/declarativeimports/platformcomponents/application.cpp bdcc9b4 src/plasma/private/applet_p.cpp 1c0515a src/plasma/private/theme_p.cpp b18e1fa src/plasma/service.cpp a512569 src/plasmapkg/plasmapkg.cpp 138b2fe Diff: https://git.reviewboard.kde.org/r/127214/diff/ Testing ------- Builds, tests pass. Thanks, Aleix Pol Gonzalez
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
