----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/ -----------------------------------------------------------
(Updated Feb. 29, 2016, 4:14 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Changes ------- Submitted with commit f40cc922540c423f424b48ec047da015353071af by Andre Heinecke to branch master. Repository: kxmlgui Description ------- While packaging Kleopatra's translations for Gpg4win I've noticed that there were blank entries in the Switchlanguagedialog. Apperantly QLocale::nativeLanguageName can return an Empty string (Qt 5.5 on Windows). This patch handles this and uses the non native QLocale::languageToString as a fallback. The idea is that a non native Name is better then no name (and a blank entry in the dialog) at all. Ideally every language would have a native name but until this is the case I think this fallback makes sense. Diffs ----- src/kswitchlanguagedialog_p.cpp 039daea Diff: https://git.reviewboard.kde.org/r/127136/diff/ Testing ------- See attached screenshots of Kleopatra's switchlanguage dialog before and after the patch. Low German is an example where the native name was empty. File Attachments ---------------- Dialog before the patch https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png Dialog after the patch https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png Thanks, Andre Heinecke
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
