> On Feb. 29, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/sycoca/kbuildsycoca.cpp, line 143 > > <https://git.reviewboard.kde.org/r/127215/diff/2/?file=445997#file445997line143> > > > > QVector maybe? > > Nick Shaforostoff wrote: > doesn't make a difference from performance perspective, see > https://marcmutz.wordpress.com/effective-qt/containers/ > but just changing qlist to qvector here increases the lib binary size by > 15kb (!)
maybe because QList is already much more used in this code? not sure - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92899 ----------------------------------------------------------- On Feb. 29, 2016, 12:27 p.m., Nick Shaforostoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127215/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2016, 12:27 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Changes are mostly related to containers/iterators, but there are also few > QString related optimizations > > note that i have made a switch from QLinkedList to just QList because it > performs better for T=<void*> > also i have changed QStringList to QSet<QString> in one place to make the > code run faster > > > Diffs > ----- > > src/services/kservice.cpp c75bce2 > src/services/kservicetype.cpp 2a73ccd > src/sycoca/kbuildmimetypefactory.cpp 340f76a > src/sycoca/kbuildservicefactory.cpp a74f2e8 > src/sycoca/kbuildsycoca.cpp e99e906 > src/sycoca/kmimeassociations.cpp 9423b27 > src/sycoca/ksycocadict.cpp f33d01a > src/sycoca/ksycocafactory.cpp e410581 > src/sycoca/ksycocautils_p.h 8db26b0 > > Diff: https://git.reviewboard.kde.org/r/127215/diff/ > > > Testing > ------- > > all tests pass, except kmimeassociationstest (fakeApplicationService is > NULL), but it fails also without my changes > > > Thanks, > > Nick Shaforostoff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
