> On March 2, 2016, 2:26 p.m., Marco Martin wrote: > > I find a bit baffling that an option is needed for this...
You are not exactly suggesting a better solution, though. Options are not needed when we can make everything work magically out of the box. However FTP servers are not exactly under our control, so it's hard to make it all work magically. Reading directory permissions is unreliable, not all FTP servers run on Unix, so others emulate stuff (and there might be ACLs, which you don't see in ls -l). kio_ftp can't just test if the renaming will be allowed by trying to create a fake file and rename it, because then what? if it fails and the server doesn't allow deletion either, it made a mess that it can't clean up.... So yeah, a way for people to turn off resuming support so that basic upload actually works on permission-restricted servers makes sense. Look at the number of options in actual FTP clients BTW.... - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93075 ----------------------------------------------------------- On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127154/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2016, 11:52 p.m.) > > > Review request for KDE Frameworks, David Edmundson, David Faure, and Marco > Martin. > > > Repository: kio > > > Description > ------- > > We have an option called "Mark partially uploaded files" in System Settings > -> Network: Settings -> Connection Preferences -> FTP Options. This one > toggles adding ".part" extension to partially transferred files through FTP > protocol. > > Other KIO slaves (such as SMB, SFTP) has already working code that supports > MarkPartial property read from kioslaverc. This patch is just exposing the > property from GUI, specifically I've created "Global Options" section (with > one checkbox) above existing "FTP Options" section. > > Originally I've created a bug report for this: > https://bugs.kde.org/show_bug.cgi?id=359636 > > > Diffs > ----- > > src/kcms/kio/kioslave.kcfg d34b691 > src/kcms/kio/netpref.h f7a0abc > src/kcms/kio/netpref.cpp 24273a3 > > Diff: https://git.reviewboard.kde.org/r/127154/diff/ > > > Testing > ------- > > Tested toggling MarkPartial on SMB, SFTP slaves. > > FISH slave was and still is ignoring it (no .part extension). > > I didn't test NFS and others. > > > Thanks, > > Martin Kostolný > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
