> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> > qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> >
> > Not sure both connects are necessary though?
This is not to disable the whole session manager thing, but just disable the
restore. So session manager is still able to terminate kwalletd.
- Xuetian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
-----------------------------------------------------------
On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 8:34 p.m.)
>
>
> Review request for KDE Frameworks and Martin Klapetek.
>
>
> Repository: kwallet
>
>
> Description
> -------
>
> I notice a kwalletd5 with "-session ....." in its command line started on my
> desktop and kwallet-pam doesn't work.
>
> Also kwalletd is dbus activated in other cases there's no point to let
> session manager to restore it.
>
>
> Diffs
> -----
>
> src/runtime/kwalletd/main.cpp 740e670
>
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
>
>
> Testing
> -------
>
> kwallet-pam back to work.
>
>
> Thanks,
>
> Xuetian Weng
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
