> On March 7, 2016, 9:29 p.m., Gregor Mi wrote: > > src/kmoretools/kmoretoolsmenufactory.cpp, lines 128-129 > > <https://git.reviewboard.kde.org/r/127237/diff/2/?file=448481#file448481line128> > > > > Thanks for the comment. However, as long as we don't know the root > > cause for the null pointers, I would feel better if the comment states > > clearly that we don't know what is happening and that it is happening on > > Windows only. > > Kåre Särs wrote: > This one is not needed at the moment (I did not get null pointers here), > but I left it there just in case. I feel it is better to loose functionality > than getting a crash ;) > > Gregor Mi wrote: > Then it's ok. General question: is there a common log file where one > could write a message in case there is nullptr which was catched?
.xsession-errors/stderr probably get the qCritical() debug output and dbgviewer on windows is logging it if running. - Kåre ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/#review93270 ----------------------------------------------------------- On March 7, 2016, 8:38 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127237/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 8:38 p.m.) > > > Review request for KDE Frameworks and Gregor Mi. > > > Repository: knewstuff > > > Description > ------- > > On Windows we sometimes get null-pointers in stead of pointers to > KMoreToolsService. This patch adds checks for null-pointers in those places > that made Kate crash in the project plugin and adds a nullptr check before > adding them to the list. > > > Diffs > ----- > > src/kmoretools/kmoretoolsmenufactory.cpp 30f4d02 > src/kmoretools/kmoretoolspresets.cpp 2405321 > > Diff: https://git.reviewboard.kde.org/r/127237/diff/ > > > Testing > ------- > > Compiled and run on windows. No crashes in Kate when right-clicking files in > the project plugin. > > > Thanks, > > Kåre Särs > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
