----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127334/#review93396 -----------------------------------------------------------
Ship it! Ship It! - Kevin Funk On March 10, 2016, 7:04 p.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127334/ > ----------------------------------------------------------- > > (Updated March 10, 2016, 7:04 p.m.) > > > Review request for KDE Frameworks, Dario Freddi and Martin Gräßlin. > > > Repository: polkit-qt-1 > > > Description > ------- > > Otherwise it fails with "test/test.cpp:49:14: error: 'qVariantValue' > was not declared in this scope". qVariantValue is a obsolete > workaround for MSVC 6, which was released 1998 and thus seems ancient > enough to change this. > > > Diffs > ----- > > test/test.cpp afb7f64333e1122d86d2692f9cbaa94a08bec800 > > Diff: https://git.reviewboard.kde.org/r/127334/diff/ > > > Testing > ------- > > Builds at least. The test doesn't run successfully though (Totals: 6 passed, > 3 failed, 0 skipped, 0 blacklisted). I doubt it did before. There's also no > target to run it. > > > Thanks, > > Heiko Becker > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel