----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127374/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- When we show a Qt window it resets all wm_states, including the SKIP_TASKBAR state that Qt doesn't support see QXcbWindow::setNetWmStates In order to set the flag we need to do it after Qt has mapped the window. (after a showEvent) Dialog previously did this using ExposeEvent which we know will happen after show. However: 1) This is a rather random fix 2) It will be called after TaskManager has been notified of a new window By merging into the same event we can make sure the flag is set before the task manager processes the new window. This means task manager will always skip plasma popups. A better fix will obviously be patching Qt to not reset flags it doesn't know about and then we can set this flag in the ctor. I shall try and do that for Qt 5.7. BUG: 332024 REVIEW: Diffs ----- src/plasmaquick/dialog.cpp 56f39c0740a1e32a9588e7461dcb45aab3fe9e85 Diff: https://git.reviewboard.kde.org/r/127374/diff/ Testing ------- Added debug in libtaskmanager, the window flags are always correct for the new window. Thanks, David Edmundson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
