> On März 16, 2016, 1:24 vorm., David Edmundson wrote: > > mtp/devicecache.cpp, line 116 > > <https://git.reviewboard.kde.org/r/127386/diff/1/?file=453199#file453199line116> > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > this line looks important > > > > from what I can tell, this patch simply tries to use every possible > > device as an MTP client skipping all the checks. > > > > I would have though that would have had some downsides. > > > > Does viewing mtp:/ list any extra entries? > > Dominik Haumann wrote: > Yes, as I understand, this scans all devices. However, non-functional > mtp-devices are then filtered out by the call of err = > LIBMTP_Detect_Raw_Devices(&rawdevices, &numrawdevices); in line 127 (left > pane). > > So this patch should just be less pedantic in the first place. I have > asked the guy on reddit to try the original version, so let's see whether > this is really needed.
I have an issue where it shows three devices for my phone, two of which don't work, and I fear that this may make it worse or re-introduce such an issue. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93581 ----------------------------------------------------------- On März 15, 2016, 5:52 nachm., Dominik Haumann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127386/ > ----------------------------------------------------------- > > (Updated März 15, 2016, 5:52 nachm.) > > > Review request for KDE Frameworks, David Faure and Philipp Schmidt. > > > Bugs: 325335 > https://bugs.kde.org/show_bug.cgi?id=325335 > > > Repository: kio-extras > > > Description > ------- > > Right now, Windows Phones (Nokia HW) is not properly recognized by kio-mtp. > > It seems the device is listed but dropped for some reason. This issues exists > for quite a long time (also in KDE 4.x), and some people provided this patch > (from bug #325335). > > I personally cannot test this patch, as I don't own a Windows Phone. > > However, given this patch works successfully for at least some users (see > also > https://www.reddit.com/r/kde/comments/4aggg0/error_with_kio_while_trying_to_open_lumia_device/), > I think we at least should give it a try. > > Adding group 'kdeframeworks' to reach a broader audience. > > Would be cool to get a proper review for this patch, or even someone who owns > such a device! > > > Diffs > ----- > > mtp/devicecache.cpp 8c5c7cf > > Diff: https://git.reviewboard.kde.org/r/127386/diff/ > > > Testing > ------- > > Compiles... > > > Thanks, > > Dominik Haumann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel