> On March 17, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > > Emmanuel Pescosta wrote: > > Would it be possible to get a test? > > autotest (is it allowed to show a dialog in KF autotests?) or more like > kpropertiesdialogtest? > > David Faure wrote: > Yes ideally this would be an autotest. We have autotests showing up > dialogs already, no problem there. What's a bit tricky is the introspection > to find the buttons and "click" them. Or just calling reject() would have > done the job for this particular crash (after some event processing).
> We have autotests showing up dialogs already Ok great :) Is it ok for everyone when I push this fix now, so that downstream can apply it to their KF 5.20 release, and provide the test next week? I need to dive into the introspection stuff first, so this will need some time ;) - Emmanuel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93651 ----------------------------------------------------------- On March 17, 2016, 10:37 a.m., Emmanuel Pescosta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127410/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 10:37 a.m.) > > > Review request for KDE Frameworks, Andreas Sturmlechner and David Faure. > > > Bugs: 360488 > https://bugs.kde.org/show_bug.cgi?id=360488 > > > Repository: kio > > > Description > ------- > > Fix crash in rename dialog > > ResizePanels must only be called in case of overwrite, all other cases > violate the preconditions. > > @Andreas: Can you please try the patch? > > > Diffs > ----- > > src/widgets/renamedialog.cpp 2d456c7 > > Diff: https://git.reviewboard.kde.org/r/127410/diff/ > > > Testing > ------- > > Yes, I tried it by overwriting a file with the same file and with a different > file -> no crash :) > > > Thanks, > > Emmanuel Pescosta > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
