----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127428/#review93737 -----------------------------------------------------------
Ship it! Looks good to me (can definitely not hurt to check the pointer for obvious reasons). - Dominik Haumann On März 19, 2016, 8:31 nachm., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127428/ > ----------------------------------------------------------- > > (Updated März 19, 2016, 8:31 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kemoticons > > > Description > ------- > > Noticed in the CI which says: Invalid plugin factory for > "kf5/emoticonsthemes/kde" > > > Diffs > ----- > > src/core/kemoticons.cpp 87e4a1116b634fdae33f42112b870c5eb1c204d0 > > Diff: https://git.reviewboard.kde.org/r/127428/diff/ > > > Testing > ------- > > Removing lib64/plugins/kf5/emoticonsthemes/kde.so locally, I got the crash > too, this fixes it. > > Of course the unittest fails then, as expected, it just doesn't crash anymore. > > I think some env vars are missing in Jenkins.... > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel